Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate “since” dart sdk mapping #1351

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Calculate “since” dart sdk mapping #1351

merged 2 commits into from
Jan 6, 2019

Conversation

pq
Copy link
Member

@pq pq commented Jan 6, 2019

In support of #1340.

/cc @bwilkerson

fyi @srawlins @chalin

Updated scorecard:

name linter dart sdk fix flutter user flutter repo pedantic stagehand status bug refs
always_declare_return_types 0.1.4 2.0.0 ✅
always_put_control_body_on_new_line 0.1.31 2.0.0 ✅
always_put_required_named_parameters_first 0.1.33 2.0.0
always_require_non_null_named_parameters 0.1.31 2.0.0 💡 ✅
always_specify_types 0.1.4 2.0.0 ✅
annotate_overrides 0.1.11 2.0.0 💡 ✅
avoid_annotating_with_dynamic 0.1.31 2.0.0 💡 #1162
avoid_bool_literals_in_conditional_expressions 0.1.46 2.0.0
avoid_types_on_closure_parameters 0.1.31 2.0.0 💡 #1099
avoid_as 0.1.5 2.0.0 ✅
avoid_catching_errors 0.1.31 2.0.0
avoid_catches_without_on_clauses 0.1.31 2.0.0
avoid_classes_with_only_static_members 0.1.31 2.0.0 ✅
avoid_double_and_int_checks 0.1.47 2.0.0
avoid_empty_else 0.1.8 2.0.0 💡 ✅ ✅ ✅
avoid_field_initializers_in_const_classes 0.1.48 2.0.0 ✅
avoid_function_literals_in_foreach_calls 0.1.30 2.0.0 ✅
avoid_implementing_value_types 0.1.62 2.1.0-dev.5.0
avoid_init_to_null 0.1.11 2.0.0 💡 ✅ ✅ ✅
avoid_js_rounded_ints 0.1.48 2.0.0
avoid_null_checks_in_equality_operators 0.1.31 2.0.0 ✅
avoid_positional_boolean_parameters 0.1.31 2.0.0
avoid_private_typedef_functions 0.1.46 2.0.0
avoid_relative_lib_imports 0.1.44 2.0.0 ✅ ✅
avoid_renaming_method_parameters 0.1.45 2.0.0 ✅
avoid_returning_null 0.1.31 2.0.0
avoid_returning_null_for_future 0.1.72 2.1.1-dev.0.0
avoid_returning_null_for_void 0.1.69 2.1.0-dev.8.0 ✅
avoid_return_types_on_setters 0.1.11 2.0.0 💡 ✅ ✅ ✅
avoid_returning_this 0.1.31 2.0.0
avoid_setters_without_getters 0.1.31 2.0.0
avoid_shadowing_type_parameters 0.1.72 2.1.1-dev.0.0
avoid_single_cascade_in_expression_statements 0.1.46 2.0.0
avoid_slow_async_io 0.1.30 2.0.0 ✅
avoid_types_as_parameter_names 0.1.45 2.0.0 ✅ ✅
avoid_unused_constructor_parameters 0.1.36 2.0.0 ✅
avoid_void_async 0.1.60 2.1.0-dev.3.0 ✅
await_only_futures 0.1.16 2.0.0 💡 ✅ ✅
camel_case_types 0.1.1 2.0.0 ✅ ✅
cancel_subscriptions 0.1.20 2.0.0 ✅ ✅ ✅
cascade_invocations 0.1.29 2.0.0 #1023, #806, #787
close_sinks 0.1.19 2.0.0 ✅
comment_references 0.1.17 2.0.0
control_flow_in_finally 0.1.16 2.0.0 ✅ ✅
constant_identifier_names 0.1.1 2.0.0
curly_braces_in_flow_control_structures 0.1.57 2.0.0
directives_ordering 0.1.30 2.0.0 ✅
empty_catches 0.1.22 2.0.0 💡 ✅
empty_constructor_bodies 0.1.1 2.0.0 💡 ✅ ✅
empty_statements 0.1.21 2.0.0 💡 ✅ ✅
file_names 0.1.54 2.0.0
flutter_style_todos 0.1.61 2.1.0-dev.5.0 ✅
hash_and_equals 0.1.11 2.0.0 ✅ ✅ ✅
implementation_imports 0.1.4 2.0.0 ✅ ✅ #1175
invariant_booleans 0.1.25 2.0.0 experimental #1321, #914, #811, #720, #674
iterable_contains_unrelated_type 0.1.17 2.0.0 ✅ ✅ #1003
join_return_with_assignment 0.1.31 2.0.0
library_names 0.1.1 2.0.0 ✅ ✅
library_prefixes 0.1.1 2.0.0 ✅
lines_longer_than_80_chars 0.1.56 2.0.0
list_remove_unrelated_type 0.1.22 2.0.0 ✅ ✅
literal_only_boolean_expressions 0.1.25 2.0.0
no_adjacent_strings_in_list 0.1.30 2.0.0 ✅
no_duplicate_case_values 0.1.30 2.0.0 ✅ ✅
non_constant_identifier_names 0.1.1 2.0.0 💡 ✅ ✅
null_closures 0.1.56 2.0.0 ✅
one_member_abstracts 0.1.1 2.0.0 #990
omit_local_variable_types 0.1.30 2.0.0 #1006
only_throw_errors 0.1.21 2.0.0
overridden_fields 0.1.18 2.0.0 ✅
package_api_docs 0.1.1 2.0.0 ✅ ✅ #213
package_prefixed_library_names 0.1.1 2.0.0 ✅ ✅
parameter_assignments 0.1.27 2.0.0
prefer_adjacent_string_concatenation 0.1.30 2.0.0 ✅ #1191
prefer_bool_in_asserts 0.1.36 2.0.0 deprecated
prefer_collection_literals 0.1.30 2.0.0 💡 ✅
prefer_conditional_assignment 0.1.31 2.0.0 💡 ✅
prefer_const_constructors 0.1.30 2.0.0 ✅
prefer_const_constructors_in_immutables 0.1.33 2.0.0 ✅
prefer_const_declarations 0.1.43 2.0.0 💡 ✅
prefer_const_literals_to_create_immutables 0.1.43 2.0.0 ✅
prefer_asserts_in_initializer_lists 0.1.33 2.0.0 ✅
prefer_constructors_over_static_methods 0.1.31 2.0.0
prefer_contains 0.1.30 2.0.0 ✅ ✅
prefer_equal_for_default_values 0.1.46 2.0.0 ✅ ✅
prefer_expression_function_bodies 0.1.30 2.0.0
prefer_final_fields 0.1.27 2.0.0 💡 ✅
prefer_final_in_for_each 0.1.78 null
prefer_final_locals 0.1.27 2.0.0 💡 ✅
prefer_foreach 0.1.31 2.0.0 ✅
prefer_function_declarations_over_variables 0.1.30 2.0.0
prefer_generic_function_type_aliases 0.1.47 2.0.0 ✅
prefer_initializing_formals 0.1.30 2.0.0 ✅
prefer_int_literals 0.1.71 2.1.0
prefer_interpolation_to_compose_strings 0.1.30 2.0.0
prefer_iterable_whereType 0.1.47 2.0.0 ✅
prefer_is_empty 0.1.30 2.0.0 ✅ ✅
prefer_is_not_empty 0.1.5 2.0.0 💡 ✅ ✅ ✅ #1232
prefer_mixin 0.1.62 2.1.0-dev.5.0
prefer_single_quotes 0.1.33 2.0.0 ✅
prefer_typing_uninitialized_variables 0.1.36 2.0.0 ✅
prefer_void_to_null 0.1.59 2.1.0-dev.1.0 ✅
public_member_api_docs 0.1.11 2.0.0
package_names 0.1.31 2.0.0 ✅ ✅
recursive_getters 0.1.30 2.0.0 ✅ ✅
slash_for_doc_comments 0.1.1 2.0.0 ✅ ✅
sort_constructors_first 0.1.11 2.0.0 ✅
sort_pub_dependencies 0.1.63 2.1.0-dev.6.0 ✅
sort_unnamed_constructors_first 0.1.11 2.0.0 ✅
super_goes_last 0.1.1 2.0.0 ✅ ✅
test_types_in_equals 0.1.16 2.0.0 ✅ ✅ ✅ #443
throw_in_finally 0.1.16 2.0.0 ✅ ✅
type_annotate_public_apis 0.1.5 2.0.0 #1121
type_init_formals 0.1.1 2.0.0 💡 ✅ ✅
unawaited_futures 0.1.19 2.0.0 ✅ #1007, #836, #534, #419
unnecessary_await_in_return 0.1.73 2.1.1-dev.0.0
unnecessary_brace_in_string_interps 0.1.30 2.0.0 ✅ ✅
unnecessary_const 0.1.54 2.0.0 ✅
unnecessary_new 0.1.54 2.0.0 ✅
unnecessary_null_aware_assignments 0.1.30 2.0.0 ✅
unnecessary_null_in_if_null_operators 0.1.30 2.0.0 ✅
unnecessary_getters_setters 0.1.1 2.0.0 ✅ ✅ #275
unnecessary_lambdas 0.1.30 2.0.0 💡
unnecessary_overrides 0.1.31 2.0.0 ✅
unnecessary_parenthesis 0.1.44 2.0.0 ✅
unnecessary_statements 0.1.36 2.0.0 ✅ ✅
unnecessary_this 0.1.30 2.0.0 💡 ✅
unrelated_type_equality_checks 0.1.16 2.0.0 ✅ ✅ ✅ ✅
use_function_type_syntax_for_parameters 0.1.72 2.1.1-dev.0.0
use_rethrow_when_possible 0.1.31 2.0.0 ✅ ✅
use_setters_to_change_properties 0.1.31 2.0.0
use_string_buffers 0.1.31 2.0.0 #777
use_to_and_as_if_applicable 0.1.31 2.0.0
valid_regexps 0.1.22 2.0.0 ✅ ✅ ✅ ✅
void_checks 0.1.49 2.0.0

@coveralls
Copy link

coveralls commented Jan 6, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.446% when pulling 9162ab0 on sinc_sdk into 531a0a9 on master.

bwilkerson
bwilkerson approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@bwilkerson bwilkerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

tool/crawl.dart Outdated Show resolved Hide resolved
@pq pq merged commit 59cefe3 into master Jan 6, 2019
@pq pq deleted the sinc_sdk branch January 6, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pq @coveralls @bwilkerson @googlebot